spi: axiado: cond_no_effect and kernel-doc fixes

Browse source

Babanpreet Singh <bbnpreetsingh@gmail.com> says:

Two small cleanups for the Axiado SPI driver, both defects present
since the driver was added in e75a6b00ad ("spi: axiado: Add driver
for Axiado SPI DB controller").

Patch 1 addresses the coccinelle cond_no_effect warning reported by
the kernel test robot on 2026-07-12 [1]: the RX-only/full-duplex
else-if arm and the trailing else arm in ax_transfer_one() have
identical bodies, so the second condition has no effect. The arms are
merged; no functional change (on x86_64/gcc 14, only
ax_transfer_one()'s object code changes, dropping the dead condition
evaluation).

Patch 2 fixes the kernel-doc comments in the driver: a copy-pasted
function name on ax_spi_get_rx_byte_for_irq(), a /** block with no
identifier line on ax_spi_process_rx_and_finalize(), and stale/missing
member documentation on struct ax_spi. This silences the driver's two
W=1 kernel-doc warnings plus five more visible when kernel-doc is run
on the header directly.

Both patches are against spi/for-next; they are independent of each
other except for touching the same file.

[1] https://lore.kernel.org/r/202607121827.djB0zLAj-lkp@intel.com/

Link: https://patch.msgid.link/20260713060807.7-1-bbnpreetsingh@gmail.com

...

This commit is contained in:

Mark Brown 2026-07-19 23:55:50 +01:00

parent 787dc62517 7720f98d08

commit b247067fb1

No known key found for this signature in database

GPG key ID: 24D68B725D5487D0

2 changed files with 13 additions and 12 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

20

drivers/spi/spi-axiado.c

View file

5

drivers/spi/spi-axiado.h

View file