[CPUFREQ] arch/x86/kernel/cpu/cpufreq: Fix unsigned return type

Browse source

In each case, the function has an unsigned return type, but returns a
negative constant to indicate an error condition.  Each function is only
called once.  For nforce2_detect_chipset, the result is only compared to 0,
and for longrun_determine_freqs, the result is stored in a variable of type
(signed) int.  Thus, for both functions, unsigned can be dropped from the
return type.

A sematic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@exists@
identifier f;
constant C;
@@

 unsigned f(...)
 { <+...
*  return -C;
 ...+> }
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Dave Jones <davej@redhat.com>

...

This commit is contained in:

Julia Lawall 2010-09-05 21:00:20 +02:00 • committed by Dave Jones

parent bec037aa6c

commit b2a33c1728

2 changed files with 2 additions and 2 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

arch/x86/kernel/cpu/cpufreq/cpufreq-nforce2.c

View file

2

arch/x86/kernel/cpu/cpufreq/longrun.c

View file