rbd: fix osd_request memory leak in __rbd_dev_header_watch_sync()

Browse source

osd_request, along with r_request and r_reply messages attached to it
are leaked in __rbd_dev_header_watch_sync() if the requested image
doesn't exist.  This is because lingering requests are special and get
an extra ref in the reply path.  Fix it by unregistering linger request
on the error path and split __rbd_dev_header_watch_sync() into two
functions to make it maintainable.

Signed-off-by: Ilya Dryomov <ilya.dryomov@inktank.com>

...

This commit is contained in:

Ilya Dryomov 2014-05-22 19:28:52 +04:00 • committed by Yan, Zheng

parent 30ba1f0202

commit b30a01f2a3

1 changed files with 85 additions and 38 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

127

drivers/block/rbd.c

View file