RDMA/rtrs: Fix some signedness bugs in error handling

Browse source

The problem is that "req->sg_cnt" is an unsigned int so if "nr" is
negative, it gets type promoted to a high positive value and the condition
is false.  This patch fixes it by handling negatives separately.

Fixes: 6a98d71dae ("RDMA/rtrs: client: main functionality")
Link: https://lore.kernel.org/r/20200519133223.GN2078@kadam
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Jack Wang <jinpu.wang@cloud.ionos.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

...

This commit is contained in:

Dan Carpenter 2020-05-19 16:32:23 +03:00 • committed by Jason Gunthorpe

parent 23bbd5818e

commit b386cd65d9

2 changed files with 4 additions and 5 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

7

drivers/infiniband/ulp/rtrs/rtrs-clt.c

View file

2

drivers/infiniband/ulp/rtrs/rtrs-srv.c

View file