enic: Bug fix: use safe queue shutdown in dev->stop

Browse source

Fix dev->stop shutdown bug where driver was stopping xmit queue and then
disabling intrs.  Fix is to disable intrs first and then stop the xmit
queue, otherwise an interrupt could cause the queue to be rewoken.  Also,
no need to explicitly do queue servicing because queues are cleaned and
reset back to initial state at end of dev->stop.  Servicing queues also
had the side-effect of also rewakening the xmit queue, which is not what
we want.

Signed-off-by: Vasanthy Kolluri <vkolluri@cisco.com>
Signed-off-by: Scott Feldman <scofeldm@cisco.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Scott Feldman 2009-12-23 13:27:30 +00:00 • committed by David S. Miller

parent fe45332ed2

commit b3d18d191b

3 changed files with 27 additions and 38 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

drivers/net/enic/enic.h

View file

62

drivers/net/enic/enic_main.c

View file

1

drivers/net/enic/vnic_intr.h

View file