ipv6:introduce function to find route for redirect

Browse source

RFC 4861 says that the IP source address of the Redirect is the
same as the current first-hop router for the specified ICMP
Destination Address, so the gateway should be taken into
consideration when we find the route for redirect.

There was once a check in commit
a6279458c5 ("NDISC: Search over
all possible rules on receipt of redirect.") and the check
went away in commit b94f1c0904
("ipv6: Use icmpv6_notify() to propagate redirect, instead of
rt6_redirect()").

The bug is only "exploitable" on layer-2 because the source
address of the redirect is checked to be a valid link-local
address but it makes spoofing a lot easier in the same L2
domain nonetheless.

Thanks very much for Hannes's help.

Signed-off-by: Duan Jiong <duanj.fnst@cn.fujitsu.com>
Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Duan Jiong 2013-09-04 19:44:21 +08:00 • committed by David S. Miller

parent 60cad4e67b

commit b55b76b221

6 changed files with 81 additions and 11 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

net/ipv6/ah6.c

View file

2

net/ipv6/esp6.c

View file

2

net/ipv6/icmp.c

View file

2

net/ipv6/ipcomp6.c

View file

3

net/ipv6/ndisc.c

View file

81

net/ipv6/route.c

View file