nfsd4: don't sleep in lease-break callback

Browse source

The NFSv4 server's fl_break callback can sleep (dropping the BKL), in
order to allocate a new rpc task to send a recall to the client.

As far as I can tell this doesn't cause any races in the current code,
but the analysis is difficult.  Also, the sleep here may complicate the
move away from the BKL.

So, just schedule some work to do the job for us instead.  The work will
later also prove useful for restarting a call after the callback
information is changed.

Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>

...

This commit is contained in:

J. Bruce Fields 2010-03-03 14:52:55 -05:00

parent 3c4ab2aaa9

commit b5a1a81e5c

3 changed files with 73 additions and 20 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

54

fs/nfsd/nfs4callback.c

View file

34

fs/nfsd/nfs4state.c

View file

5

fs/nfsd/state.h

View file