xdrgen: Reject specifications that define a name twice

Browse source

When an RPC specification defines the same type or constant name
more than once, currently xdrgen emits every definition without
complaint. The duplication surfaces later as a C compiler error
about a redefined struct or function that points at generated code
instead of the actual offending line in the .x source.

RFC 4506 Section 6.4 places constant and type identifiers in a
single name space that must be unique within a specification. Add
a semantic check that enforces this rule.

Link: https://patch.msgid.link/20260712203451.124902-4-cel@kernel.org
Signed-off-by: Chuck Lever <cel@kernel.org>

...

This commit is contained in:

Chuck Lever 2026-07-12 16:34:49 -04:00

parent e1391920c6

commit b75e1a256d

6 changed files with 101 additions and 11 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

10

tools/net/sunrpc/xdrgen/subcmds/declarations.py

View file

7

tools/net/sunrpc/xdrgen/subcmds/definitions.py

View file

7

tools/net/sunrpc/xdrgen/subcmds/lint.py

View file

7

tools/net/sunrpc/xdrgen/subcmds/source.py

View file

61

tools/net/sunrpc/xdrgen/xdr_ast.py

View file

20

tools/net/sunrpc/xdrgen/xdr_parse.py

View file