drm: Add DRM_MODESET_LOCK_BEGIN/END helpers

Browse source

This patch adds a couple of helpers to remove the boilerplate involved
in grabbing all of the modeset locks.

I've also converted the obvious cases in drm core to use the helpers.

The only remaining instance of drm_modeset_lock_all_ctx() is in
drm_framebuffer. It's complicated by the state clear that occurs on
deadlock. ATM, there's no way to inject code in the deadlock path with
the helpers, so it's unfit for conversion.

Changes in v2:
- Relocate ret argument to the end of the list (Daniel)
- Incorporate Daniel's doc suggestions (Daniel)

Suggested-by: Daniel Vetter <daniel@ffwll.ch>
Reviewed-by: Daniel Vetter <daniel@ffwll.ch>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20181129150423.239081-4-sean@poorly.run

...

This commit is contained in:

Sean Paul 2018-11-29 10:04:17 -05:00

parent 2aa3eef85d

commit b7ea04d299

6 changed files with 83 additions and 78 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

51

drivers/gpu/drm/drm_atomic_helper.c

View file

14

drivers/gpu/drm/drm_color_mgmt.c

View file

15

drivers/gpu/drm/drm_crtc.c

View file

6

drivers/gpu/drm/drm_modeset_lock.c

View file

16

drivers/gpu/drm/drm_plane.c

View file

59

include/drm/drm_modeset_lock.h

View file