fs/ntfs3: Fix error handling in indx_insert_into_root()

Browse source

There are three bugs in this code:
1) If indx_get_root() fails, then return -EINVAL instead of success.
2) On the "/* make root external */" -EOPNOTSUPP; error path it should
   free "re" but it has a memory leak.
3) If indx_new() fails then it will lead to an error pointer dereference
   when we call put_indx_node().

I've re-written the error handling to be more clear.

Fixes: 82cae269cf ("fs/ntfs3: Add initialization of super block")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Kari Argillander <kari.argillander@gmail.com>
Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>

...

This commit is contained in:

Dan Carpenter 2021-08-24 10:51:04 +03:00 • committed by Konstantin Komarov

parent 8c83a4851d

commit b8155e95de

No known key found for this signature in database

GPG key ID: A9B0331F832407B6

1 changed files with 16 additions and 20 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

36

fs/ntfs3/index.c

View file