scsi: hisi_sas: Add some checks to avoid free'ing a sas_task twice

Browse source

If the SCSI host enters EH, any pending IO will be processed by SCSI
EH. However it is possible that SCSI EH will try to abort the IO and
also at the same time the IO completes in the driver. In this situation
there is a small chance of freeing the sas_task twice.

Then if another IO re-uses freed sas_task before the second time of
free'ing sas_task, it is possible to free incorrect sas_task.

To avoid this situation, add some checks to increase reliability.  The
sas_task task state flag SAS_TASK_STATE_ABORTED is used to mutually
protect the LLDD and libsas freeing the task.

Signed-off-by: Xiang Chen <chenxiang66@hisilicon.com>
Signed-off-by: John Garry <john.garry@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

...

This commit is contained in:

Xiang Chen 2018-05-02 23:56:25 +08:00 • committed by Martin K. Petersen

parent 24cf43612d

commit b81b6cce58

3 changed files with 18 additions and 29 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

4

drivers/scsi/hisi_sas/hisi_sas_main.c

View file

22

drivers/scsi/hisi_sas/hisi_sas_v2_hw.c

View file

21

drivers/scsi/hisi_sas/hisi_sas_v3_hw.c

View file