isdn/gigaset: fix non-heap pointer deallocation

Browse source

at_state structures may be allocated individually or as part of a
cardstate or bc_state structure. The disconnect() function handled
both cases, creating a risk that it might try to deallocate an
at_state structure that had not been allocated individually.
Fix by splitting disconnect() into two variants handling cases
with and without an associated B channel separately, and adding
an explicit check.

Spotted with Coverity.

Signed-off-by: Tilman Schmidt <tilman@imap.cc>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Tilman Schmidt 2014-10-11 13:46:30 +02:00 • committed by David S. Miller

parent 846ac30135

commit b8324f9420

1 changed files with 70 additions and 41 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

111

drivers/isdn/gigaset/ev-layer.c

View file