ALSA: bebob: Uninitialized id returned by saffirepro_both_clk_src_get

Browse source

commit d1d0b6b668 upstream.

snd_bebob_stream_check_internal_clock() may get an id from
saffirepro_both_clk_src_get (via clk_src->get()) that was uninitialized.

a) make logic in saffirepro_both_clk_src_get explicit
b) test if id used in snd_bebob_stream_check_internal_clock matches array size

[fixed missing signed prefix to *_maps[] by tiwai]

Signed-off-by: Christian Vogel <vogelchr@vogel.cx>
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Luis Henriques <luis.henriques@canonical.com>

...

This commit is contained in:

Christian Vogel 2014-10-25 13:40:41 +02:00 • committed by Luis Henriques

parent 977d22b6df

commit b945baffbb

2 changed files with 63 additions and 17 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

64

sound/firewire/bebob/bebob_focusrite.c

View file

18

sound/firewire/bebob/bebob_stream.c

View file