ALSA: hda - fix ELD memory leak

Browse source

memset(eld) clears eld->proc_entry which will leak the struct
snd_info_entry when unloading module.

Fix it by
- memset only the fields before eld->eld_buffer
- set eld->eld_valid to true _after_ all eld fields have been filled

Cc: <stable@kernel.org>
Cc: Pierre-louis Bossart <pierre-louis.bossart@intel.com>
Acked-by: Stephen Warren <swarren@nvidia.com>
Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

...

This commit is contained in:

Wu Fengguang 2011-11-16 16:29:46 +08:00 • committed by Takashi Iwai

parent e53de8f00c

commit b95d68b817

3 changed files with 9 additions and 10 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

5

sound/pci/hda/hda_eld.c

View file

3

sound/pci/hda/hda_local.h

View file

11

sound/pci/hda/patch_hdmi.c

View file