SUNRPC: Remove duplicate universal address generation

Browse source

RPC universal address generation is currently done in several places:
rpcb_clnt.c, nfs4proc.c xprtsock.c, and xprtrdma.c.  Remove the
redundant cases that convert a socket address to a universal
address.  The nfs4proc.c case takes a pre-formatted presentation
address string, not a socket address, so we'll leave that one.

Because the new uaddr constructor uses the recently introduced
rpc_ntop(), it now supports proper "::" shorthanding for IPv6
addresses.  This allows the kernel to register properly formed
universal addresses with the local rpcbind service, in _all_ cases.

The kernel can now also send properly formed universal addresses in
RPCB_GETADDR requests, and support link-local properly when
encoding and decoding IPv6 addresses.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

...

This commit is contained in:

Chuck Lever 2009-08-09 15:09:35 -04:00 • committed by Trond Myklebust

parent a02d692611

commit ba809130bc

4 changed files with 29 additions and 46 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

1

include/linux/sunrpc/xprt.h

View file

48

net/sunrpc/rpcb_clnt.c

View file

8

net/sunrpc/xprtrdma/transport.c

View file

18

net/sunrpc/xprtsock.c

View file