ice: always check VF VSI pointer values

Browse source

The ice_get_vf_vsi function can return NULL in some cases, such as if
handling messages during a reset where the VSI is being removed and
recreated.

Several places throughout the driver do not bother to check whether this
VSI pointer is valid. Static analysis tools maybe report issues because
they detect paths where a potentially NULL pointer could be dereferenced.

Fix this by checking the return value of ice_get_vf_vsi everywhere.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
Tested-by: Konrad Jankowski <konrad0.jankowski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>

...

This commit is contained in:

Jacob Keller 2022-04-11 16:29:03 -07:00 • committed by Tony Nguyen

parent 9880d3d6f9

commit baeb705fd6

6 changed files with 77 additions and 7 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

5

drivers/net/ethernet/intel/ice/ice_devlink.c

View file

7

drivers/net/ethernet/intel/ice/ice_repr.c

View file

32

drivers/net/ethernet/intel/ice/ice_sriov.c

View file

28

drivers/net/ethernet/intel/ice/ice_vf_lib.c

View file

5

drivers/net/ethernet/intel/ice/ice_virtchnl.c

View file

7

drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c

View file