NFSD: use (un)lock_inode instead of fh_(un)lock for file operations

Browse source

When locking a file to access ACLs and xattrs etc, use explicit locking
with inode_lock() instead of fh_lock().  This means that the calls to
fh_fill_pre/post_attr() are also explicit which improves readability and
allows us to place them only where they are needed.  Only the xattr
calls need pre/post information.

When locking a file we don't need I_MUTEX_PARENT as the file is not a
parent of anything, so we can use inode_lock() directly rather than the
inode_lock_nested() call that fh_lock() uses.

Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>

...

This commit is contained in:

NeilBrown 2022-07-26 16:45:30 +10:00 • committed by Chuck Lever

parent debf16f0c6

commit bb4d53d66e

4 changed files with 30 additions and 23 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

6

fs/nfsd/nfs2acl.c

View file

4

fs/nfsd/nfs3acl.c

View file

9

fs/nfsd/nfs4state.c

View file

34

fs/nfsd/vfs.c

View file