bcachefs: Use a heap for handling overwrites in btree node scan

Browse source

Fix an O(n^2) issue when we find many overlapping (overwritten) btree
nodes - especially when one node overwrites many smaller nodes.

This was discovered to be an issue with the bcachefs
merge_torture_flakey test - if we had a large btree that was then
emptied, the number of difficult overwrites can be unbounded.

Cc: Kuan-Wei Chiu <visitorckw@gmail.com>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

...

This commit is contained in:

Kent Overstreet 2024-12-06 19:23:22 -05:00

parent dec6c0aac4

commit bbe36bd099

2 changed files with 86 additions and 48 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

133

fs/bcachefs/btree_node_scan.c

View file

1

fs/bcachefs/btree_node_scan_types.h

View file