staging: rtl8723bs: update _rtw_pktfile_read() to return error codes

Browse source

The function _rtw_pktfile_read() currently returns a uint and clamps
the requested read length if it exceeds the remaining data. This
behavior makes it impossible to propagate error codes from internal
calls like skb_copy_bits() and leads to incomplete data processing.

This patch updates the function to:
    1. Return -EINVAL if the remaining data is less than the requested length,
       ensuring callers always get the full amount of data they expect.

    2. Propagate the negative error code from skb_copy_bits().

    3. Change the return type from uint to int to support these error codes.

To avoid breaking git bisect, this patch also updates all call sites
(set_qos, update_attrib, and rtw_xmitframe_coalesce) in the same commit.
By doing so, the error-producing function and its error-handling callers
remain in sync, preventing runtime failures at this commit point.

Signed-off-by: Minu Jin <s9430939@naver.com>
Link: https://patch.msgid.link/20260127153811.1592900-2-s9430939@naver.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

...

This commit is contained in:

Minu Jin 2026-01-28 00:38:09 +09:00 • committed by Greg Kroah-Hartman

parent 1d264b88ae

commit bc4df274dc

4 changed files with 50 additions and 23 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

44

drivers/staging/rtl8723bs/core/rtw_xmit.c

View file

6

drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c

View file

2

drivers/staging/rtl8723bs/include/xmit_osdep.h

View file

21

drivers/staging/rtl8723bs/os_dep/xmit_linux.c

View file