TTY: serial/mpsc, clean up init/remove functions

Browse source

There is a chain of up to 4 nested ifs in init and remove functions.
Instead, make the code linear and use goto's to handle failures.

Remove unneeded cast from mpsc_release_port by referencing pi->port
directly. And finally, use dev_dbg instead of pr_debug given we have
dev->dev node.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

...

This commit is contained in:

Jiri Slaby 2016-01-12 10:49:33 +01:00 • committed by Greg Kroah-Hartman

parent 1fba6a594c

commit bca1481ec4

1 changed files with 79 additions and 84 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

149

drivers/tty/serial/mpsc.c

View file