s390/qeth: fix MAC address update sequence

Browse source

When changing the MAC address on a L2 qeth device, current code first
unregisters the old address, then registers the new one.
If HW rejects the new address (or the IO fails), the device ends up with
no operable address at all.

Re-order the code flow so that the old address only gets dropped if the
new address was registered successfully. While at it, add logic to catch
some corner-cases.

Signed-off-by: Julian Wiedmann <jwi@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Julian Wiedmann 2018-04-19 12:52:09 +02:00 • committed by David S. Miller

parent a936b1ef37

commit bcacfcbc82

1 changed files with 31 additions and 24 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

55

drivers/s390/net/qeth_l2_main.c

View file