rtw88: remove misleading module parameter rtw_fw_support_lps

Browse source

The module parameter rtw_fw_support_lps is misleading. It
is not used to represent the firmware's property, but to
determine if driver wants to ask firmware to enter LPS.

However, driver should better enable/disable PS through
cfg80211_ops::set_power_mgmt instead.
For example, one could use iw command to set PS state.

  $ sudo iw wlanX set power_save [on/off]

So rtw_fw_support_lps should be removed because it is
misleading and useless. Instead of checking the parameter,
set PS mode according to IEEE80211_CONF_PS.

Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

...

This commit is contained in:

Yan-Hsuan Chuang 2019-10-02 10:31:28 +08:00 • committed by Kalle Valo

parent 04b786e009

commit bcde60e599

3 changed files with 25 additions and 18 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

9

drivers/net/wireless/realtek/rtw88/mac80211.c

View file

33

drivers/net/wireless/realtek/rtw88/main.c

View file

1

drivers/net/wireless/realtek/rtw88/main.h

View file