ASoC: codec drivers: sort the reg_defaults tables

Browse source

Peter Ujfalusi <peter.ujfalusi@linux.intel.com> says:

reg_defaults must be sorted by ascending register address, since
regcache_lookup_reg() locates entries in it with bsearch().  When a table is
not sorted, bsearch() cannot find the entries which follow a descending step,
so regcache_reg_needs_sync() falls back to reporting that a sync is needed for
them.  Those registers are then written to the device on every regcache_sync()
even when they were never touched.

See commit fd80df352b ("regcache: Add support for sorting defaults arrays")
for the same problem in a different context.

Affected tables:
  ml26124_reg                1 of 79 entries unreachable
  cx2072x_reg_defaults      75 of 132 entries unreachable
  max9860_reg_defaults       1 of 14 entries unreachable
  stih407_sas_reg_defaults   1 of 2 entries unreachable

Link: https://patch.msgid.link/20260805122811.13713-1-peter.ujfalusi@linux.intel.com

...

This commit is contained in:

Mark Brown 2026-08-07 15:57:50 +01:00

parent 9b57f08ab5 bbd73fb224

commit bce4f1fd27

No known key found for this signature in database

GPG key ID: 24D68B725D5487D0

4 changed files with 66 additions and 64 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

134

sound/soc/codecs/cx2072x.c

View file

2

sound/soc/codecs/max9860.c

View file

4

sound/soc/codecs/ml26124.c

View file

2

sound/soc/codecs/sti-sas.c

View file