bpf: Fix key serial argument of bpf_lookup_user_key()

Browse source

The underlying lookup_user_key() function uses a signed 32 bit integer
for key serial numbers because legitimate serial numbers are positive
(and > 3) and keyrings are negative.  Using a u32 for the keyring in
the bpf function doesn't currently cause any conversion problems but
will start to trip the signed to unsigned conversion warnings when the
kernel enables them, so convert the argument to signed (and update the
tests accordingly) before it acquires more users.

Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Reviewed-by: Roberto Sassu <roberto.sassu@huawei.com>
Link: https://lore.kernel.org/r/84cdb0775254d297d75e21f577089f64abdfbd28.camel@HansenPartnership.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>

...

This commit is contained in:

James Bottomley 2025-06-17 10:57:36 -04:00 • committed by Alexei Starovoitov

parent f5527f0171

commit bd07bd12f2

7 changed files with 10 additions and 9 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

kernel/trace/bpf_trace.c

View file

2

tools/testing/selftests/bpf/bpf_kfuncs.h

View file

5

tools/testing/selftests/bpf/progs/rcu_read_lock.c

View file

4

tools/testing/selftests/bpf/progs/test_lookup_key.c

View file

2

tools/testing/selftests/bpf/progs/test_sig_in_xattr.c

View file

2

tools/testing/selftests/bpf/progs/test_verify_pkcs7_sig.c

View file

2

tools/testing/selftests/bpf/progs/verifier_ref_tracking.c

View file