xfs: refactor ->diff_two_keys callsites

Browse source

Create wrapper functions around ->diff_two_keys so that we don't have to
remember what the return values mean, and adjust some of the code
comments to reflect the longtime code behavior.  We're going to
introduce more uses of ->diff_two_keys in the next patch, so reduce the
cognitive load for readers by doing this refactoring now.

Suggested-by: Dave Chinner <david@fromorbit.com>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Dave Chinner <dchinner@redhat.com>

...

This commit is contained in:

Darrick J. Wong 2023-04-11 19:00:10 -07:00

parent ee5fe8ff6d

commit bd7e795108

3 changed files with 91 additions and 45 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

57

fs/xfs/libxfs/xfs_btree.c

View file

55

fs/xfs/libxfs/xfs_btree.h

View file

24

fs/xfs/scrub/btree.c

View file