cifs: avoid race during socket reconnect between send and recv

Browse source

When a TCP connection gets reestablished by the sender in cifs_reconnect,
There is a chance for race condition with demultiplex thread waiting in
cifs_readv_from_socket on the old socket. It will now return -ECONNRESET.

This condition is handled by comparing socket pointer before and after
sock_recvmsg. If the socket pointer has changed, we should not call
cifs_reconnect again, but instead retry with new socket.

Also fixed another bug in my prev mchan commits.
We should always reestablish session (even if binding) on a channel
that needs reconnection.

Signed-off-by: Shyam Prasad N <sprasad@microsoft.com>
Signed-off-by: Steve French <stfrench@microsoft.com>

...

This commit is contained in:

Shyam Prasad N 2021-10-25 05:44:10 +00:00 • committed by Steve French

parent 73f9bfbe3d

commit bda487ac4b

3 changed files with 6 additions and 24 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

14

fs/cifs/connect.c

View file

3

fs/cifs/smb2pdu.c

View file

13

fs/cifs/transport.c

View file