sfc: Clean up waits for flash/EEPROM operations

Browse source

Make falcon_spi_wait() ignore the write timer - it is only relevant to
write commands, it only works for the device that contains VPD, and it
might not be initialised properly at all.

Rename falcon_spi_fast_wait() to falcon_spi_wait_write(), reflecting
its use, and make it wait up to 10 ms (not 1 ms) since buffered writes
to EEPROM may take this long to complete.

Make both wait functions sleep instead of busy-waiting.

Replace wait for command completion at top of falcon_spi_cmd() with a
single poll; no command should be running when the function starts.

Correct some comments.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Ben Hutchings 2008-12-12 21:33:50 -08:00 • committed by David S. Miller

parent 1ab00629f0

commit be4ea89c8d

3 changed files with 39 additions and 23 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

58

drivers/net/sfc/falcon.c

View file

2

drivers/net/sfc/mtd.c

View file

2

drivers/net/sfc/spi.h

View file