ipv4: Avoid reading user iov twice after raw_probe_proto_opt

Browse source

Ever since raw_probe_proto_opt was added it had the problem of
causing the user iov to be read twice, once during the probe for
the protocol header and once again in ip_append_data.

This is a potential security problem since it means that whatever
we're probing may be invalid.  This patch plugs the hole by
firstly advancing the iov so we don't read the same spot again,
and secondly saving what we read the first time around for use
by ip_append_data.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Herbert Xu 2014-11-07 21:27:09 +08:00 • committed by David S. Miller

parent 32b5913a93

commit c008ba5bdc

1 changed files with 54 additions and 8 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

62

net/ipv4/raw.c

View file