btrfs: cloned bios must not be iterated by bio_for_each_segment_all

Browse source

We've started using cloned bios more in 4.13, there are some specifics
regarding the iteration.  Filipe found [1] that the raid56 iterated a
cloned bio using bio_for_each_segment_all, which is incorrect. The
cloned bios have wrong bi_vcnt and this could lead to silent
corruptions.  This patch adds assertions to all remaining
bio_for_each_segment_all cases.

[1] https://patchwork.kernel.org/patch/9838535/

Reviewed-by: Liu Bo <bo.li.liu@oracle.com>
Signed-off-by: David Sterba <dsterba@suse.com>

...

This commit is contained in:

David Sterba 2017-07-13 18:10:07 +02:00

parent 1014f3d68f

commit c09abff87f

4 changed files with 7 additions and 0 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

1

fs/btrfs/compression.c

View file

1

fs/btrfs/disk-io.c

View file

3

fs/btrfs/extent_io.c

View file

2

fs/btrfs/inode.c

View file