s390/qeth: fix discipline unload after setup error

Browse source

Device initialization code usually first loads a subdriver
(via qeth_core_load_discipline()), and then runs its setup() callback.
If this fails, it rolls back the load via qeth_core_free_discipline().

qeth_core_free_discipline() expects the options.layer attribute to be
initialized, but on error in setup() that's currently not the case.
Resulting in misbalanced symbol_put() calls.

Fix this by setting options.layer when loading the subdriver.

Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Julian Wiedmann 2018-09-26 18:29:04 +02:00 • committed by David S. Miller

parent a70fee3b0f

commit c1a935f6ec

4 changed files with 2 additions and 4 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

drivers/s390/net/qeth_core_main.c

View file

2

drivers/s390/net/qeth_core_sys.c

View file

1

drivers/s390/net/qeth_l2_main.c

View file

1

drivers/s390/net/qeth_l3_main.c

View file