media: mediatek: vcodec: fix possible unbalanced PM counter

Browse source

It is possible that mtk_vcodec_enc_pw_on fails, and in that scenario
the PM counter is not incremented, and subsequent call to
mtk_vcodec_enc_pw_off decrements the counter, leading to a PM imbalance.
Fix by bailing out of venc_if_encode in the case when mtk_vcodec_enc_pw_on
fails.

Fixes: 4e855a6efa ("[media] vcodec: mediatek: Add Mediatek V4L2 Video Encoder Driver")
Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
Signed-off-by: Sebastian Fricke <sebastian.fricke@collabora.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>

...

This commit is contained in:

Eugen Hristev 2023-12-28 13:32:40 +02:00 • committed by Hans Verkuil

parent eb005c801e

commit c28d4921a1

3 changed files with 8 additions and 3 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

4

drivers/media/platform/mediatek/vcodec/encoder/mtk_vcodec_enc_pm.c

View file

2

drivers/media/platform/mediatek/vcodec/encoder/mtk_vcodec_enc_pm.h

View file

5

drivers/media/platform/mediatek/vcodec/encoder/venc_drv_if.c

View file