drm/modes: parse_cmdline: Stop parsing extras after bpp / refresh at ', '

Browse source

Before this commit it was impossible to add an extra mode argument after
a bpp or refresh specifier, combined with an option, e.g.
video=HDMI-1:720x480-24e,rotate=180 would not work, either the "e" to
force enable would need to be dropped or the ",rotate=180", otherwise
the mode_option would not be accepted.

This commit fixes this by fixing the length calculation if extras_ptr
is set to stop the extra parsing at the start of the options (stop at the
',' options_ptr points to).

Acked-by: Maxime Ripard <mripard@kernel.org>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191118155134.30468-3-hdegoede@redhat.com

...

This commit is contained in:

Hans de Goede 2019-11-18 16:51:24 +01:00

parent 83e14ea3a6

commit c2ed3e9419

3 changed files with 33 additions and 4 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

10

drivers/gpu/drm/drm_modes.c

View file

1

drivers/gpu/drm/selftests/drm_cmdline_selftests.h

View file

26

drivers/gpu/drm/selftests/test-drm_cmdline_parser.c

View file