ASoC: cs35l41: Fix use of an uninitialised variable

Browse source

The loop checking PDN_DONE doesn't check the return value from
regmap_read, nor does it initialise val. This means if regmap_read fails
val will be checked for the PDN_DONE bit whilst being uninitialised.

Fix this up by switching to regmap_read_poll_timeout which tidies up the
code and avoids the uninitialised variable.

Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20210914141349.30218-1-ckeepax@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>

...

This commit is contained in:

Charles Keepax 2021-09-14 15:13:44 +01:00 • committed by Mark Brown

parent 6d66c5ccf5

commit c2f14cc2bc

No known key found for this signature in database

GPG key ID: 24D68B725D5487D0

1 changed files with 5 additions and 14 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

19

sound/soc/codecs/cs35l41.c

View file