drm/i915/gt: Push engine stopping into reset-prepare

Browse source

Push the engine stop into the back reset_prepare (where it already was!)
This allows us to avoid dangerously setting the RING registers to 0 for
logical contexts. If we clear the register on a live context, those
invalid register values are recorded in the logical context state and
replayed (with hilarious results).

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190716124931.5870-2-chris@chris-wilson.co.uk

...

This commit is contained in:

Chris Wilson 2019-07-16 13:49:28 +01:00

parent fff8102aae

commit c30d5dc653

3 changed files with 53 additions and 61 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

16

drivers/gpu/drm/i915/gt/intel_lrc.c

View file

58

drivers/gpu/drm/i915/gt/intel_reset.c

View file

40

drivers/gpu/drm/i915/gt/intel_ringbuffer.c

View file