batman-adv: Remove unnecessary hardif_list_lock

Browse source

hardif_list_lock is unneccessary because we already ensure that no
multiple admin operations can take place through rtnl_lock.
hardif_list_lock only adds additional overhead and complexity.

Critical functions now check whether they are called with rtnl_lock
using ASSERT_RTNL.

It indirectly fixes the problem that orig_hash_del_if() expects that
only one interface is deleted from hardif_list at a time, but
hardif_remove_interfaces() removes all at once and then calls
orig_hash_del_if().

Reported-by: Linus Lüssing <linus.luessing@web.de>
Signed-off-by: Sven Eckelmann <sven@narfation.org>

...

This commit is contained in:

Sven Eckelmann 2011-05-03 11:51:38 +02:00

parent 61906ae86d

commit c3caf5196c

4 changed files with 13 additions and 24 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

net/batman-adv/bat_sysfs.c

View file

30

net/batman-adv/hard-interface.c

View file

3

net/batman-adv/main.c

View file

2

net/batman-adv/soft-interface.c

View file