bcachefs: Ensure srcu lock is not held too long

Browse source

The SRCU read lock that btree_trans takes exists to make it safe for
bch2_trans_relock() to deref pointers to btree nodes/key cache items we
don't have locked, but as a side effect it blocks reclaim from freeing
those items.

Thus, it's important to not hold it for too long: we need to
differentiate between bch2_trans_unlock() calls that will be only for a
short duration, and ones that will be for an unbounded duration.

This introduces bch2_trans_unlock_long(), to be used mainly by the data
move paths.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

...

This commit is contained in:

Kent Overstreet 2023-10-30 12:30:52 -04:00

parent 6dfa10ab22

commit c4accde498

4 changed files with 40 additions and 13 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

42

fs/bcachefs/btree_iter.c

View file

4

fs/bcachefs/btree_iter.h

View file

6

fs/bcachefs/btree_locking.c

View file

1

fs/bcachefs/btree_types.h

View file