HID: stop exporting hid_snto32()

Browse source

The only user of hid_snto32() is Logitech HID++ driver, which always
calls hid_snto32() with valid size (constant, either 12 or 8) and
therefore can simply use sign_extend32().

Make the switch and remove hid_snto32(). Move snto32() and s32ton() to
avoid introducing forward declaration.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Link: https://patch.msgid.link/20241003144656.3786064-2-dmitry.torokhov@gmail.com
[bentiss: fix checkpatch warning]
Signed-off-by: Benjamin Tissoires <bentiss@kernel.org>

...

This commit is contained in:

Dmitry Torokhov 2024-10-03 07:46:51 -07:00 • committed by Benjamin Tissoires

parent ae9b956cb2

commit c653ffc283

3 changed files with 32 additions and 38 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

63

drivers/hid/hid-core.c

View file

6

drivers/hid/hid-logitech-hidpp.c

View file

1

include/linux/hid.h

View file