drm/amdkfd: Add an optional argument into update queue operation(v2)

Browse source

Currently, queue is updated with data in queue_properties.
And all allocated resource in queue_properties will not
be freed until the queue is destroyed.

But some properties(e.g., cu mask) bring some memory
management headaches(e.g., memory leak) and make code
complex. Actually they have been copied to mqd and
don't have to persist in queue_properties.

Add an argument into update queue to pass such properties,
then we can remove them from queue_properties.

v2: Don't use void *.

Suggested-by: Felix Kuehling <Felix.Kuehling@amd.com>
Signed-off-by: Lang Yu <lang.yu@amd.com>
Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

...

This commit is contained in:

Lang Yu 2021-10-08 12:47:18 +08:00 • committed by Alex Deucher

parent f7e053435c

commit c6e559eb3b

9 changed files with 52 additions and 35 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

5

drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c

View file

2

drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.h

View file

3

drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager.h

View file

23

drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_cik.c

View file

10

drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v10.c

View file

10

drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v9.c

View file

26

drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_vi.c

View file

2

drivers/gpu/drm/amd/amdkfd/kfd_priv.h

View file

6

drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c

View file