tracing: Replace all non-returning strlcpy with strscpy

Browse source

strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit.
This is both inefficient and can lead to linear read
overflows if a source string is not NUL-terminated [1].
In an effort to remove strlcpy() completely [2], replace
strlcpy() here with strscpy().

No return values were used, so direct replacement with strlcpy is safe.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89

Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20230516143956.1367827-1-azeemshaikh38@gmail.com

...

This commit is contained in:

Azeem Shaikh 2023-05-16 14:39:56 +00:00 • committed by Kees Cook

parent 7afbe5defb

commit c7dce4c5d9

5 changed files with 10 additions and 10 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

8

kernel/trace/trace.c

View file

4

kernel/trace/trace_events.c

View file

4

kernel/trace/trace_events_inject.c

View file

2

kernel/trace/trace_kprobe.c

View file

2

kernel/trace/trace_probe.c

View file