spi: bcm2835aux: remove dangerous uncontrolled read of fifo

Browse source

This read of the fifo is a potential candidate for a race condition
as the spi transfer is not necessarily finished and so can lead to
an early read of the fifo that still misses data.

So it has been removed.

Fixes: 1ea29b39f4 ("spi: bcm2835aux: add bcm2835 auxiliary spi device...")
Suggested-by: Hubert Denkmair <h.denkmair@intence.de>
Signed-off-by: Martin Sperl <kernel@martin.sperl.org>
Acked-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

...

This commit is contained in:

Martin Sperl 2019-03-30 09:30:59 +00:00 • committed by Mark Brown

parent 7188a6f0ee

commit c7de8500fd

No known key found for this signature in database

GPG key ID: 24D68B725D5487D0

1 changed files with 0 additions and 7 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

7

drivers/spi/spi-bcm2835aux.c

View file