drm/i915: Protect against drm_gem_object not being the first member

Browse source

Dave Airlie spotted that we had a potential bug should we ever rearrange
the drm_i915_gem_object so not the base drm_gem_object was not its first
member. He noticed that we often convert the return of
drm_gem_object_lookup() immediately into drm_i915_gem_object and then
check the result for nullity. This is only valid when the base object is
the first member and so the superobject has the same address. Play safe
instead and use the compiler to convert back to the original return
address for sanity testing.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

...

This commit is contained in:

Chris Wilson 2011-02-19 11:31:06 +00:00

parent 548f245ba6

commit c872522663

5 changed files with 16 additions and 16 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

18

drivers/gpu/drm/i915/i915_gem.c

View file

4

drivers/gpu/drm/i915/i915_gem_execbuffer.c

View file

4

drivers/gpu/drm/i915/i915_gem_tiling.c

View file

4

drivers/gpu/drm/i915/intel_display.c

View file

2

drivers/gpu/drm/i915/intel_overlay.c

View file