drm/amdgpu: revert "Adjust removal control flow for smu v13_0_2"

Browse source

commit fb1c93c2e9 upstream.

Calling amdgpu_device_ip_resume_phase1() during shutdown leaves the
HW in an active state and is an unbalanced use of the IP callbacks.

Using the IP callbacks like this can lead to memory leaks, double
free and imbalanced reference counters.

Leaving the HW in an active state can lead to DMA accesses to memory now
freed by the driver.

Both is a complete no-go for driver unload so completely revert the
workaround for now.

This reverts commit f5c7e77970.

Signed-off-by: Christian König <christian.koenig@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

...

This commit is contained in:

Christian König 2024-01-10 15:19:29 +01:00 • committed by Greg Kroah-Hartman

parent a48895e9f5

commit c884129fdc

4 changed files with 1 additions and 65 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

32

drivers/gpu/drm/amd/amdgpu/amdgpu_device.c

View file

32

drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c

View file

1

drivers/gpu/drm/amd/amdgpu/amdgpu_reset.h

View file

1

drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.h

View file