drm/i915: Dumb down the semaphore logic

Browse source

While I think the previous code is correct, it was hard to follow and
hard to debug. Since we already have a ring abstraction, might as well
use it to handle the semaphore updates and compares.

I don't expect this code to make semaphores better or worse, but you
never know...

v2:
Remove magic per Keith's suggestions.
Ran Daniel's gem_ring_sync_loop test on this.

v3:
Ignored one of Keith's suggestions.

v4:
Removed some bloat per Daniel's recommendation.

Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Keith Packard <keithp@keithp.com>
Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
Signed-off-by: Keith Packard <keithp@keithp.com>

...

This commit is contained in:

Ben Widawsky 2011-09-14 20:32:47 -07:00 • committed by Keith Packard

parent e0dac65ed4

commit c8c99b0f0d

4 changed files with 126 additions and 47 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

3

drivers/gpu/drm/i915/i915_gem_execbuffer.c

View file

13

drivers/gpu/drm/i915/i915_reg.h

View file

149

drivers/gpu/drm/i915/intel_ringbuffer.c

View file

8

drivers/gpu/drm/i915/intel_ringbuffer.h

View file