net: bcmgenet: connect and disconnect from the PHY state machine

Browse source

phy_disconnect() is the only way to guarantee that we are not going to
schedule more work on the PHY state machine workqueue for that
particular PHY device.

This fixes an issue where a network interface was suspended prior to a
system suspend/resume cycle and would then be resumed as part of
mdio_bus_resume(), since the GENET interface clocks would have been
disabled, this basically resulted in bus errors to appear since we are
invoking the GENET driver adjust_link() callback.

Fixes: b6e978e504 ("net: bcmgenet: add suspend/resume callbacks")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Florian Fainelli 2014-11-10 18:06:20 -08:00 • committed by David S. Miller

parent 93ecd2607f

commit c96e731c93

3 changed files with 8 additions and 1 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

6

drivers/net/ethernet/broadcom/genet/bcmgenet.c

View file

1

drivers/net/ethernet/broadcom/genet/bcmgenet.h

View file

2

drivers/net/ethernet/broadcom/genet/bcmmii.c

View file