net: fman: Use physical address for userspace interfaces

Browse source

Before 262f2b782e ("net: fman: Map the base address once"), the
physical address of the MAC was exposed to userspace in two places: via
sysfs and via SIOCGIFMAP. While this is not best practice, it is an
external ABI which is in use by userspace software.

The aforementioned commit inadvertently modified these addresses and
made them virtual. This constitutes and ABI break.  Additionally, it
leaks the kernel's memory layout to userspace. Partially revert that
commit, reintroducing the resource back into struct mac_device, while
keeping the intended changes (the rework of the address mapping).

Fixes: 262f2b782e ("net: fman: Map the base address once")
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Sean Anderson <sean.anderson@seco.com>
Acked-by: Madalin Bucur <madalin.bucur@oss.nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Sean Anderson 2022-10-20 11:50:41 -04:00 • committed by David S. Miller

parent f812747693

commit c99f0f7e68

4 changed files with 10 additions and 10 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

4

drivers/net/ethernet/freescale/dpaa/dpaa_eth.c

View file

2

drivers/net/ethernet/freescale/dpaa/dpaa_eth_sysfs.c

View file

12

drivers/net/ethernet/freescale/fman/mac.c

View file

2

drivers/net/ethernet/freescale/fman/mac.h

View file