crypto: x86/salsa20 - cleanup and convert to skcipher API

Browse source

Convert salsa20-asm from the deprecated "blkcipher" API to the
"skcipher" API, in the process fixing it up to use the generic helpers.
This allows removing the salsa20_keysetup() and salsa20_ivsetup()
assembly functions, which aren't performance critical; the C versions do
just fine.

This also fixes the same bug that salsa20-generic had, where the state
array was being maintained directly in the transform context rather than
on the stack or in the request context.  Thus, if multiple threads used
the same Salsa20 transform concurrently they produced the wrong results.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

...

This commit is contained in:

Eric Biggers 2018-01-05 11:09:59 -08:00 • committed by Herbert Xu

parent eb772f37ae

commit c9a3ff8f22

4 changed files with 46 additions and 359 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

184

arch/x86/crypto/salsa20-i586-asm_32.S

View file

114

arch/x86/crypto/salsa20-x86_64-asm_64.S

View file

105

arch/x86/crypto/salsa20_glue.c

View file

2

crypto/Kconfig

View file