ASoC: davinci-mcasp: Update PDIR (pin direction) register handling

Browse source

When McASP is master and the PDIR for the clock pins are configured as
outputs before the clocking is configured it will output whatever clock
is generated at the moment internally.
The clock will switch to the correct rate only when the we start the clock
generators.

To avoid this we must only set the pin as output after the clock is
configured and enabled.

AXR pins configured as outputs behaves somehow interesting as well:
when McASP is not enabled and the pin is selected as output it will not
honor the DISMOD settings for the inactive state, but will pull the pin
down.

Add a new bitfield and mark the pins there which needs to be output and
set the pins only at the time when they will behave correctly.

On stream stop configure the pins back to input which makes them to obey
the global pin configuration regarding to pull up/down.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

...

This commit is contained in:

Peter Ujfalusi 2018-11-16 15:41:39 +02:00 • committed by Mark Brown

parent 1003c27acf

commit ca3d943334

No known key found for this signature in database

GPG key ID: 24D68B725D5487D0

2 changed files with 85 additions and 32 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

88

sound/soc/davinci/davinci-mcasp.c

View file

29

sound/soc/davinci/davinci-mcasp.h

View file