iio: imu: inv_mpu6050: fix possible deadlock between mutex and iio

Browse source

Detected by kernel circular locking dependency checker.

We are locking iio mutex (iio_device_claim_direct_mode) after
locking our internal mutex. But when the buffer starts, iio first
locks its mutex and then we lock our internal one.

To avoid possible deadlock, we need to use the same order
everwhere. So we change the ordering by locking first iio mutex,
then our internal mutex.

Fixes: 68cd6e5b20 ("iio: imu: inv_mpu6050: fix lock issues by using our own mutex")
Cc: stable@vger.kernel.org
Signed-off-by: Jean-Baptiste Maneyrol <jmaneyrol@invensense.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

...

This commit is contained in:

Jean-Baptiste Maneyrol 2018-04-30 12:14:09 +02:00 • committed by Jonathan Cameron

parent 3b37c41f0e

commit ca4c8fc97e

1 changed files with 16 additions and 18 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

34

drivers/iio/imu/inv_mpu6050/inv_mpu_core.c

View file