drm/msm: fix locking inconsistency for gpu->hw_init()

Browse source

Most, but not all, paths where calling the with struct_mutex held.  The
fast-path in msm_gem_get_iova() (plus some sub-code-paths that only run
the first time) was masking this issue.

So lets just always hold struct_mutex for hw_init().  And sprinkle some
WARN_ON()'s and might_lock() to avoid this sort of problem in the
future.

Signed-off-by: Rob Clark <robdclark@gmail.com>

...

This commit is contained in:

Rob Clark 2017-06-13 09:15:36 -04:00

parent 42a105e9cf

commit cb1e38181a

6 changed files with 17 additions and 16 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

13

drivers/gpu/drm/msm/adreno/a5xx_gpu.c

View file

11

drivers/gpu/drm/msm/adreno/a5xx_power.c

View file

2

drivers/gpu/drm/msm/adreno/adreno_device.c

View file

2

drivers/gpu/drm/msm/adreno/adreno_gpu.c

View file

3

drivers/gpu/drm/msm/msm_gem.c

View file

2

drivers/gpu/drm/msm/msm_gpu.c

View file