nfsd: fix callback restarts

Browse source

Checking the rpc_client pointer is not a reliable way to detect
backchannel changes: cl_cb_client is changed only after shutting down
the rpc client, so the condition cl_cb_client = tk_client will always be
true.

Check the RPC_TASK_KILLED flag instead, and rewrite the code to avoid
the buggy cl_callbacks list and fix the lifetime rules due to double
calls of the ->prepare callback operations method for this retry case.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>

...

This commit is contained in:

Christoph Hellwig 2015-04-30 11:49:24 +02:00 • committed by J. Bruce Fields

parent ef2a1b3e10

commit cba5f62b18

3 changed files with 24 additions and 33 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

52

fs/nfsd/nfs4callback.c

View file

1

fs/nfsd/nfs4state.c

View file

4

fs/nfsd/state.h

View file